Conversation
moibra05
requested review from
jaredlockhart and
yashikakhurana
as code owners
Contributor
Author
|
mikewilli
reviewed
Nov 19, 2025
moibra05
force-pushed
the
13721
branch
3 times, most recently
from
092cc80 to
eba101f
Compare
moibra05
force-pushed
the
13721
branch
3 times, most recently
from
2cbe276 to
407fcdc
Compare
Member
freshstrangemusic
left a comment
freshstrangemusic
left a comment
There was a problem hiding this comment.
we might want to consider moving some of the metrics calculation gunk (e.g., every function we're adding that isnt going to be called outside of /results/) off of the model itself and into the results app, but that can be done in a follow-up.
moibra05
force-pushed
the
13721
branch
2 times, most recently
from
da8e50c to
20a8d20
Compare
freshstrangemusic
approved these changes
Dec 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #13721